This repository was archived by the owner on Jun 29, 2018. It is now read-only.
Extract soundcloud client_id and api js urls constants to a changeable variable #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.SOUND_CLOUD_API_JS variables ... so we can replace the soundcloud js url, if we want to use our custom, forked version of their sdk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, I can use different soundcloud client_id just by
Popcorn.SOUND_CLOUD_CLIENT_ID = "123";before initializing a popcorn soundcloud wrapper.This change is backward compatible - it just uses the old client_id token, if it hasnt been changed.